don't use pointwise isapprox for rough array comparisons #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IainNZ
added a commit
that referenced
this pull request
Aug 25, 2015
don't use pointwise isapprox for rough array comparisons
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in JuliaLang/julia#12393, the
roughlycomparison for arrays is not really right, because it does a pointwiseisapproxcomparison. Without a user-specified absolute tolerance, this will make[0,1]not be roughly equal to[1e-15,1], which is probably not intended.This changes the test to use the new
isapproxarray functions from JuliaLang/julia#12472.This PR should probably wait until JuliaLang/Compat.jl#130 lands and is tagged so that the corresponding Compat version can be required.