Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent samplerate API #51

Open
ssfrr opened this issue Aug 29, 2019 · 1 comment
Open

consistent samplerate API #51

ssfrr opened this issue Aug 29, 2019 · 1 comment
Milestone

Comments

@ssfrr
Copy link
Collaborator

ssfrr commented Aug 29, 2019

Throughout a bunch of the audio code I write samplerates are not handled consistently. For instance the SampleBuf constructor takes the samplerate as a required argument, but in many other places where I want code that can also accept regular Arrays I usually include samplerate as an optional keyword argument that affects how any frequency arguments are interpreted. I have a bunch of notes with pros and cons of various APIs for handling samplerates - I need to pick one and use it consistently.

@ssfrr ssfrr added this to the v3.0 milestone Mar 20, 2020
@bramtayl
Copy link
Member

Maybe samplerate should return a unitful quantity too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants