-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
empty!() for CircularDeque, add it to docs, add some other missing things to docs #317
Merged
+42
−2
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
564d3c9
Add empty!() for CircularBuffer. Add circ_buffer.rst to docs. Add cir…
5460ab9
Add missing CircularDeque functions to docs.
142ecdc
Move * Priority Queue to under * Queue
ffbbb80
empty!(cb) = cb.first = 1; empty!(cb.buffer)
625bcae
Add empty!(cb) test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
.. _ref-circular_buffer: | ||
|
||
-------------- | ||
CircularBuffer | ||
-------------- | ||
|
||
The ``CircularBuffer`` type implements a circular buffer of fixed ``capacity`` where new items are pushed to the back of the list, overwriting values in a circular fashion. | ||
|
||
Usage:: | ||
|
||
a = CircularBuffer{Int}(n) # allocate an Int buffer with maximum capacity n | ||
isfull(a) # test whether the buffer is full | ||
isempty(a) # test whether the buffer is empty | ||
empty!(a) # reset the buffer | ||
capacity(a) # return capacity | ||
length(a) # get the number of elements currently in the buffer | ||
size(a) # same as length(a) | ||
push!(a, 10) # add an element to the back and overwrite front if full | ||
unshift!(a, 10) # add an element to the front and overwrite back if full | ||
append!(a, [1, 2, 3, 4]) # push at most last `capacity` items | ||
convert(Vector{Float64}, a) # convert items to type Float64 | ||
eltype(a) # return type of items | ||
a[1] # get the element at the front | ||
a[end] # get the element at the back |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also need to reset
cb.first = 1
. Is there a reason you didn't just callempty!(cb.buffer)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you add a quick test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make. Test added. Your suggestion is much faster. Thanks for the help!