From eb2e6c4bc30c4129362bcc04a8ea67435e80e89b Mon Sep 17 00:00:00 2001 From: Milan Bouchet-Valat Date: Mon, 29 Aug 2016 18:31:18 +0200 Subject: [PATCH] Remove FIXME about map() Shorter written that way for now. Filed as JuliaStats/NullableArrays.jl#144. --- test/join.jl | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/join.jl b/test/join.jl index 0e668ed775..8615eb6f84 100644 --- a/test/join.jl +++ b/test/join.jl @@ -18,12 +18,11 @@ module TestJoin Job = NullableArray(["Lawyer", "Doctor", "Florist", Nullable(), "Farmer"])) # (Tests use current column ordering but don't promote it) - # FIXME: Vector{Bool} should not be needed if map(::NullableArray) behave properly - right = outer[Vector{Bool}(map(x->!isnull(x), outer[:Job])), [:Name, :ID, :Job]] - left = outer[Vector{Bool}(map(x->!isnull(x), outer[:Name])), :] - inner = left[Vector{Bool}(map(x->!isnull(x), left[:Job])), :] + right = outer[[!isnull(x) for x in outer[:Job]], [:Name, :ID, :Job]] + left = outer[[!isnull(x) for x in outer[:Name]], :] + inner = left[[!isnull(x) for x in left[:Job]], :] semi = unique(inner[:, [:ID, :Name]]) - anti = left[Vector{Bool}(map(isnull, left[:Job])), [:ID, :Name]] + anti = left[[isnull(x) for x in left[:Job]], [:ID, :Name]] @test isequal(join(name, job, on = :ID), inner) @test isequal(join(name, job, on = :ID, kind = :inner), inner)