-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Iterators.partition #3212
add Iterators.partition #3212
Conversation
CI failure is unrelated. |
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition!
@quinnj - as you probably know I want to add it to allow easy splitting of a data frame into record batches for Arrow.jl. |
Yeah, I saw the discourse post. I wonder if we should add a note about |
Ah - you are right. I need to change the implementation so that |
After this change it will be enough to write |
Ah yes, you're right. Nice; that's very simple/clean. |
OK - I have made the changes and tested that @nalimilan - as usual (no rush) - it would be great if you had a look at the PR again. |
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Thank you! I will merge this after we make DataFrames.jl 1.4.4 release. |
Thank you! |
Having this function would be convenient in cases like https://discourse.julialang.org/t/arrow-stream-usage-clarification/89508.
With this PR adding new functionalities for 1.5 release starts. I will manage patches to 1.4.x releases in a separate branch if they are needed.