-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop lying about WeakRefStringArray eltype #17
Conversation
getindex() always returns a String, never a WeakRefString.
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 1 1
Lines 47 47
=======================================
Hits 37 37
Misses 10 10
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 1 1
Lines 47 47
=======================================
Hits 37 37
Misses 10 10
Continue to review full report at Codecov.
|
This is a quick fix. Longer-term, there should be another type parameter to say whether the array can contain missing values or not (as for |
Note that this actually fixes the corruption bug I noted at nalimilan/FreqTables.jl#16. It was due to the fact that the eltype was defined as |
enhances JuliaData#17 so that WeakRefStringArray allows missing iff the underlying WeakRefString Array allows missing
enhances JuliaData#17 so that WeakRefStringArray allows missing iff the underlying WeakRefString Array allows missing
enhances JuliaData#17 so that WeakRefStringArray allows missing iff the underlying WeakRefString Array allows missing
getindex()
always returns aString
, never aWeakRefString
.See JuliaData/CSV.jl#118 (comment).