Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow getindex in lookup_or_eval :call #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benlorenz
Copy link
Contributor

This is needed for CxxWrap.jl to avoid unknown call f introduced by ccall lowering getindex, see #613.

Probably for code like this:

    push!(call_exp.args, :(@inbounds ccall(__cxxwrap_pointers[$funcidx][1], $c_return_type, ($(c_arg_types...),), $(argsymbols...)))) # Direct pointer call

This does fix my reproducer from #613.
But I don't really know how a proper test for this would look like.

cc: @barche

this is needed for cxxwrap
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (376d172) to head (e6ca748).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/interpret.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   81.03%   84.06%   +3.02%     
==========================================
  Files          12       12              
  Lines        2636     2654      +18     
==========================================
+ Hits         2136     2231      +95     
+ Misses        500      423      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benlorenz
Copy link
Contributor Author

Regarding the CI failures:

  • nightly seems to be known
  • doctest failures might be because they are now running with julia 1.11 instead of 1.10? (Running them locally works with 1.10 and fails with 1.11)
  • I have no idea for the windows failures:
interpret.jl: Error During Test at D:\a\JuliaInterpreter.jl\JuliaInterpreter.jl\test\runtests.jl:16
  Got exception outside of a @test
  LoadError: IOError: unlink("C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\jl_pCdyngh2HK"): permission denied (EACCES)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant