-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no method matching MersenneTwister(::typeof(abs2), ::Array{Complex{Float64},1}) #227
Comments
* Nograd for MersenneTwister * MersenneTwister frule * Bumps patch version * Bump patch version
Should this package test Zygote, to catch such things? Possibly just |
Ideally we would, but Zygote has a fairly elaborate CI pipeline, so it would take some work to get this set up. |
Why do you say elaborate? https://github.com/FluxML/Zygote.jl/blob/master/.travis.yml looks standard. Or the |
We could copy what we do in ChainRulesCore for ChainRules integration tests already. Would be good to have a separate runner for this, so the test suite doesn't take forever to run. |
I guess I was more referring to the fact that they've got a separate gitlab CI (I believe for the benefit of GPU stuff?) run set up when you invoke bors: https://github.com/FluxML/Zygote.jl/blob/master/.gitlab-ci.yml But I suppose a regular CI run that doesn't handle the GPU stuff would be an improvement over nothing. |
OK, yes hooking up the GPU tests sounds harder. But the basic level would have caught this. ChainRulesCore's Cirrus CI at https://github.com/JuliaDiff/ChainRulesCore.jl/blob/master/.cirrus.yml looks like exactly the right sort of thing. |
I think this is also hitting me in FluxML/Flux.jl#1264 |
+1 on running Zygote tests here as well |
My failing CI is now shining bright and green, thanks Seth and Co! |
+1 for Zygote tests in ChainRules! |
I suddenly got a mysterious error on CI from a call to Zygote.gradient
I haven't touched the code that threw the error in a long time so something must have gone wild in Zygote or ChainRules
link to CI failure: https://github.com/baggepinnen/SpectralDistances.jl/runs/840227039#step:4:721
link to failing call: https://github.com/baggepinnen/SpectralDistances.jl/blob/master/test/test_diff.jl#L204
Probably caused by 697e7e4
The text was updated successfully, but these errors were encountered: