Don't use std(in|out|err) as identifiers #641
Conversation
src/DocChecks.jl
Outdated
| @@ -172,7 +172,7 @@ mutable struct Result | |||
| file :: String # File in which the doctest is written. Either `.md` or `.jl`. | |||
| value :: Any # The value returned when evaluating `input`. | |||
| hide :: Bool # Semi-colon suppressing the output? | |||
| stdout :: IOBuffer # Redirected STDOUT/STDERR gets sent here. | |||
| io :: IOBuffer # Redirected STDOUT/STDERR gets sent here. | |||
There was a problem hiding this comment.
It shouldn't be necessary to change field names.
There was a problem hiding this comment.
Fair point, though arguably this is a better name anyway. ¯\_(ツ)_/¯ I can change it back if that'd be preferable.
There was a problem hiding this comment.
I like that stdout is a little bit more specific/informative w.r.t. the purpose of that field, although either has pros and cons. As such, since we don't have to make this change, maybe keep it as stdout for now?
|
The failure on nightly is fixed in 31044e5 |
src/DocChecks.jl
Outdated
| @@ -172,7 +172,7 @@ mutable struct Result | |||
| file :: String # File in which the doctest is written. Either `.md` or `.jl`. | |||
| value :: Any # The value returned when evaluating `input`. | |||
| hide :: Bool # Semi-colon suppressing the output? | |||
| stdout :: IOBuffer # Redirected STDOUT/STDERR gets sent here. | |||
| io :: IOBuffer # Redirected STDOUT/STDERR gets sent here. | |||
There was a problem hiding this comment.
I like that stdout is a little bit more specific/informative w.r.t. the purpose of that field, although either has pros and cons. As such, since we don't have to make this change, maybe keep it as stdout for now?
|
Thanks for restarting CI, @mortenpi! Could you merge and tag? |
Needed for JuliaLang/julia#25959. In that PR, the lowercase names
stdin,stdout, andstderrwill be claimed by Base, so this avoids overwriting those names, which should hopefully allow documentation to build on that PR.