-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: expand sparse least squares example to other algorithms (Douglas-Rachford) #79
Comments
In that example, a function can be passed as For other algorithms, including I think this is once again a documentation issue: feel free to leave this open, I’ll just adjust the title. |
It seems as if ProximalAlgorithms.DRLS(tol = 10 * TOL, directions=acc) doesn't care about the values of the tol parameter. |
Do you have an example? It definitely cares about the value of |
It's a rather large data set, can I send it by email? I have tested your test_small_lasso.jl and DRLS works fine on that small data, but not on my larger data. The interesting point is that all other methods from that file works fine on my data. |
How big is it? Otherwise you could upload the data somewhere and share the link here, in case it’s fine to have the data publicly available |
@patwa67 looks like there is a bug in the way DRLS displays progress: ProximalAlgorithms.jl/src/algorithms/drls.jl Lines 188 to 190 in 3de04a9
Fixing it, thanks! |
I managed to get most algorithms running on the Sparse regression example, but not the DRLS algorithm. I guess it should be applicable to sparse regression, but what needs to be done with:
drls = ProximalAlgorithms.DRLS(tol=1e-4,verbose=true)
solution_dr, iterations_dr = drls(x0=zeros(n_features+1),f=training_loss, g=reg,gamma=1e-7)
The text was updated successfully, but these errors were encountered: