-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust test/examples.jl #207
Conversation
bors try |
tryBuild failed: |
Fascinatingly now it is only partly broken |
Maybe the failure in Windows is due to the incompatibility between powershell and bash? I just added the patch that is supposed to use bash everywhere. I'm not sure why it'd fail on ubuntu, though https://github.com/JuliaGPU/KernelAbstractions.jl/runs/1882919107#step:9:128 I can't repro it locally |
bors try |
tryBuild failed: |
bors help |
bors delegate=@tkf |
I think it's bors delegate=tkf |
✌️ tkf can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks, Dilum! |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
bors try |
tryAlready running a review |
bors try |
tryAlready running a review |
Why all this business with the load path? Why not just do |
Ha! If it were just that simple, |
So, it looks like this is a Julia 1.6-specific problem JuliaLang/julia#39631 (I think this is orthogonal to the issue that Pkg.test is not enough for this mono-repo setting.) |
This reverts commit 37b736d.
right you need to add |
I believe the behavior of 1.6 is a bug. You shouldn't need anything in the top-level dependencies for transitive dependencies. If it's in the manifest, it should work. |
OK, github action worked in my repo tkf#1 (esp https://github.com/tkf/KernelAbstractions.jl/runs/1883606478) so I think this is good to go. I'm not merging via bors since I don't know if it supports merging to a non-default branch. |
tryTimed out. |
Thanks Taka! |
I'm not sure I follow. You should be able to do the following: julia test.jl Where the contents of import Pkg
# KernelAbstractions
Pkg.develop(Pkg.PackageSpec(path = pwd()))
# CUDAKernels
Pkg.develop(Pkg.PackageSpec(path = joinpath(pwd(), "lib", "CUDAKernals")))
Pkg.test(["KernelAbstractions", "CUDAKernels"]) Does that not work? If it doesn't work, we should patch Pkg to make it work. |
This is a PR onto #200.
I think the test is failing because
Base.current_project()
doesn't work nicely with--project
:A quick workaround may be to use
Base.load_path_setup_code()
to propagate load path etc to the child processes.