From d4ad9f22d4c90e0158e6506ea3ec901f5af51b6f Mon Sep 17 00:00:00 2001 From: Simone Carlo Surace <51025924+simsurace@users.noreply.github.com> Date: Sat, 10 Feb 2024 15:45:39 +0100 Subject: [PATCH] Enable periodic kernel in example Now that https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/pull/528 has been merged, we can try re-enabling the `PeriodicKernel` --- examples/1-mauna-loa/script.jl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/examples/1-mauna-loa/script.jl b/examples/1-mauna-loa/script.jl index c685d659..221ed061 100644 --- a/examples/1-mauna-loa/script.jl +++ b/examples/1-mauna-loa/script.jl @@ -100,9 +100,7 @@ plotdata() # We define a couple of helper functions to simplify the kernel construction: SE(θ) = θ.σ^2 * with_lengthscale(SqExponentialKernel(), θ.ℓ) -## PeriodicKernel is broken, see https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/issues/389 -##Per(θ) = with_lengthscale(PeriodicKernel(; r=[θ.ℓ/2]), θ.p) # NOTE- discrepancy with GaussianProcesses.jl -Per(θ) = with_lengthscale(SqExponentialKernel(), θ.ℓ) ∘ PeriodicTransform(1 / θ.p) +Per(θ) = with_lengthscale(PeriodicKernel(; r=[θ.ℓ/2]), θ.p) # NOTE- discrepancy with GaussianProcesses.jl RQ(θ) = θ.σ^2 * with_lengthscale(RationalQuadraticKernel(; α=θ.α), θ.ℓ) #md nothing #hide