Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect functions never called for files < 35 bytes #176

Closed
ssfrr opened this issue Mar 20, 2018 · 1 comment
Closed

detect functions never called for files < 35 bytes #176

ssfrr opened this issue Mar 20, 2018 · 1 comment

Comments

@ssfrr
Copy link
Contributor

ssfrr commented Mar 20, 2018

The logic here will return the query with format"UNKNOWN" if it hits EOF while going through the magic bytes list, but some of the magic byte strings are quite long (35 bytes). So if you have a short file that relies on a detection function (like .wav), that detection file will never get called.

@timholy
Copy link
Member

timholy commented Mar 3, 2021

I'm pretty sure this is fixed now, but if not a MWE would be great.

EDIT: probably fixed in #295

@timholy timholy closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants