Formats supported in package submodules

[TransGirlCodes]

Hi, when adding format and specifying a package that supports the reader and writer for a format, if the reader and writer are in some submodule do I have to qualify the submodule or is the package name adequate? e.g. which of these two possibilities is the correct one?

add_format(format"FASTA", (), [".fasta", ".fa"], [Symbol("BioSequences.FASTA")])

or

add_format(format"FASTA", (), [".fasta", ".fa"], [:BioSequences])

Thanks!

[alhirzel]

Here is an idiom that works for me.

using FileIO

module ManyLoadersSavers
	import FileIO
	using FileIO: @format_str

	function load end

	"""implement loader for a fictional filetype, .FileType"""
	module FileTypeIO
		using Test: @test
		using ..ManyLoadersSavers
		using ..ManyLoadersSavers: load
		import FileIO
		using FileIO: @format_str

		function ManyLoadersSavers.load(f::FileIO.File{format"filetype"})
			@test "MagicString" == read(f.filename, String)
		end

		function __init__()
			FileIO.add_format(format"filetype", (), [".FileType"])
			FileIO.add_loader(format"filetype", :ManyLoadersSavers)
		end
	end

	# artifically pass a module check in FileIO
	abstract type DummyTypeWithAnyName end
	load(f::DummyTypeWithAnyName) = error("never gets called")
end

# this is what the current check uses
mods = map(m -> m.module, methods(ManyLoadersSavers.load))
@info "here are the modules detected" mods

mktempdir() do dir

	# generate test file
	fn = joinpath(dir, "asdf.FileType")
	open(fn, "w") do fh
		write(fh, "MagicString")
	end

	# attempt to load using FileIO
	@info "Loaded" load(fn)
end

[timholy]

In #295 it because possible to supply the module directly, so this can be closed. Thanks @alhirzel for posting the workaround.