Update example code in README.md #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without an explicit `Array{Int64}` instantiation the following error is produced (in julia 0.5.0): `ERROR: MethodError: no method matching write(::HDF5.HDF5File, ::String, ::Array{UnitRange{Int64},1})`
andyferris
reviewed
Oct 24, 2016
| @@ -115,7 +115,7 @@ end | |||
| Convenience functions for attributes attached to datasets are also provided: | |||
|
|
|||
| ```julia | |||
| A=[1:10] | |||
| A=Array{Int64}(1:10) | |||
There was a problem hiding this comment.
It's a bit shorter to write collect(1:10) or [i for i=1:10], or your example could be rand(Int, 10) or something.
There was a problem hiding this comment.
Better to write it as A = Vector{Int64}(1:10)
|
The motivation behind the PR is pretty uncontroversial... I'm a little surprised there hasn't been a single comment in weeks. |
|
bump |
Merged
|
Closer by #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without an explicit
Array{Int64}instantiation the following error is produced (in julia 0.5.0):ERROR: MethodError: no method matching write(::HDF5.HDF5File, ::String, ::Array{UnitRange{Int64},1})