Do not treat static parameter as is_always_defined
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
aviatesk
approved these changes
Aug 20, 2025
aviatesk
added a commit
to mlechu/JuliaLowering.jl
that referenced
this pull request
Aug 20, 2025
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
adienes
pushed a commit
to adienes/julia
that referenced
this pull request
Nov 20, 2025
…Lowering.jl#41) Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #37 (comment), static parameters are not always guaranteed to be defined. Therefore, they should not be used as a sufficient condition for
is_always_defined. (I think this makes #37 ready to merge.)This change also affects the generated ir for closures, so the corresponding test cases have been updated accordingly.