Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly forward the value of --depwarn to the test subprocess #1963

Closed
wants to merge 1 commit into from
Closed

Correctly forward the value of --depwarn to the test subprocess #1963

wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Member

Before this PR:

Value provided to --depwarn by user Value passed to test subprocess
error error
yes yes
no yes

After this PR:

Value provided to --depwarn by user Value passed to test subprocess
error error
yes yes
no no

@DilumAluthge
Copy link
Member Author

Since this is a bugfix, would it be possible to backport this PR to Julia 1.5.1?

@fredrikekre
Copy link
Member

The current behaviour is expected, cf. #1763. I have meant to fix JLOptions but forgot about it. I will put it on my list.

@DilumAluthge
Copy link
Member Author

The current behaviour is expected, cf. #1763. I have meant to fix JLOptions but forgot about it. I will put it on my list.

I see. Once you fix JLOptions, will explicitly passing --depwarn=no be passed to the subprocess?

@fredrikekre
Copy link
Member

Yea. The problem right now is that we can't see the difference between --depwarn=no and not specifying at all.

@DilumAluthge
Copy link
Member Author

Ok cool, I'll close this in favor of the fix you describe.

@DilumAluthge DilumAluthge deleted the patch-1 branch August 16, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants