Commit 21d15ed
authored
Refactor stacktrace processing and display pipeline for more clarity and less redundancy (#55841)
The current stacktrace display pipeline has 2 different ways to show
repetition:
<img width="382" alt="image"
src="https://github.com/user-attachments/assets/77199c68-f78b-4118-9cd4-2c9b5c9cf917">
And each of these uses two separate printing paths, leading to other
inconsistencies, like sometimes top-level scope is shown and sometimes
it isn't, and sometimes the frame counter includes the hidden frames and
sometimes it doesn't.
I merged the two pathways and display the cycles more nicely using line
characters, and extracted some of the filtering into separate functions.
I also added a comment to document the stacktrace processing pipeline.
~~Keeping as a draft to look at CI results and get feedback.~~
Current state of PR:
<img width="235" alt="image"
src="https://github.com/user-attachments/assets/edd7a0cc-0160-497a-a8fc-ce5864328e58"
/>
Original idea:
<img width="253" alt="image"
src="https://github.com/user-attachments/assets/f8c045e8-bed1-46c3-8f85-0e7ba703e0e1">1 parent c230f9f commit 21d15ed
File tree
5 files changed
+319
-160
lines changed- base
- stdlib/REPL/test
- test
5 files changed
+319
-160
lines changed
0 commit comments