Make throw when p is not running.

JuliaLang · Oct 9, 2017 · 2c5226d · 2c5226d
1 parent 9156fb4
commit 2c5226d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/base/process.jl b/base/process.jl
@@ -342,11 +342,8 @@ Get the process ID of a running process. Returns `-1` if the
 process is not running.
 """
 function Base.getpid(p::Process)
-    if p.handle != C_NULL
-        ccall(:jl_uv_process_pid, Cint, (Ptr{Void},), p.handle)
-    else
-        Cint(-1)
-    end
+    p.handle != C_NULL || error("process not running")
+    ccall(:jl_uv_process_pid, Cint, (Ptr{Void},), p.handle)
 end
 
 struct ProcessChain <: AbstractPipe

diff --git a/test/spawn.jl b/test/spawn.jl
@@ -227,7 +227,7 @@ let out = Pipe(), proc, pid
     close(out.in)
     @test parse(Int32, read(out, String)) == pid
     @test success(proc)
-    @test getpid(proc) == -1
+    @test_throws ErrorException getpid(proc)
 end
 
 # issue #6310