Skip to content

Commit

Permalink
Pass through the right test directory for test/runtests
Browse files Browse the repository at this point in the history
  • Loading branch information
@kshyatt
kshyatt committed Dec 14, 2016
1 parent bb070ff commit 55c2c61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

using Base.Test

Base.Test.runtests(ARGS)
Base.Test.runtests(ARGS, test_dir=pwd())

5 comments on commit 55c2c61

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit curious which of them fail if you don't do this

@kshyatt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens is that it can't find the joinpath(JULIA_HOME, "../../test") on Travis because it doesn't have the "normal" structure, I guess. So the include(joinpath(test_dir, "choosetests.jl")) fails.

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not just travis, any binary install will have a different structure. there are variables for this, DATAROOTDIR I think

@kshyatt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my laptop, running in my top-level julia dir (where I cloned julia), I get that Base.DATAROOTDIR is ../share which doesn't exist?

@kshyatt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, because I need JULIA_HOME in front.

Please sign in to comment.