Skip to content

Commit

Permalink
More cautious legacy_color conversion in Logging (#53280)
Browse files Browse the repository at this point in the history 
Can be seen as a follow-on from #51829, also wants
JuliaLang/StyledStrings.jl#37
 to behave as expected.
  • Loading branch information
@tecosaur
tecosaur authored Feb 15, 2024
1 parent 7fcf9c8 commit 61c3521
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion stdlib/Logging/src/ConsoleLogger.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,10 @@ function handle_message(logger::ConsoleLogger, level::LogLevel, message, _module
# Format lines as text with appropriate indentation and with a box
# decoration on the left.
color, prefix, suffix = logger.meta_formatter(level, _module, group, id, filepath, line)::Tuple{Union{Symbol,Int},String,String}
color = StyledStrings.Face(foreground=StyledStrings.Legacy.legacy_color(color))
lcolor = StyledStrings.Legacy.legacy_color(color)
if !isnothing(lcolor)
color = StyledStrings.Face(foreground=lcolor)
end
minsuffixpad = 2
buf = IOBuffer()
iob = IOContext(buf, stream)
Expand Down

5 comments on commit 61c3521

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your job failed.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed logs indicate the problem lies with the new cache_owner function (@vchuravy @aviatesk):

      From worker 3:    ERROR: LoadError: MethodError: no method matching cache_owner(::BaseBenchmarks.InferenceBenchmarks.InferenceBenchmarker)                                                                                                           
      From worker 3:    The function `cache_owner` exists, but no method is defined for this combination of argument types.                                                                                                                                
      From worker 3:                                                                                                         
      From worker 3:    Closest candidates are:                                                                                                                                                                                                            
      From worker 3:      cache_owner(!Matched::REPL.REPLCompletions.REPLInterpreter)                                                                                                                                                                      
      From worker 3:       @ REPL /home/nanosoldier/.julia/scratchspaces/89f34f1a-2e6b-52eb-a20f-77051b03b735/workdir/jl_cnO28l/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPLCompletions.jl:552                                                         
      From worker 3:      cache_owner(!Matched::Core.Compiler.NativeInterpreter)                                                                                                                                                                           
      From worker 3:       @ Core compiler/types.jl:407                                                                                                                                                                                                    
      From worker 3:                                                                                                                                                                                                                                       
      From worker 3:    Stacktrace:                                                                                                                                                                                                                        
      From worker 3:      [1] Core.CodeInstance(interp::BaseBenchmarks.InferenceBenchmarks.InferenceBenchmarker, result::Core.Compiler.InferenceResult, valid_worlds::Core.Compiler.WorldRange)        
      From worker 3:        @ Core.Compiler ./compiler/typeinfer.jl:329                                                                                                                                                                                    
      From worker 3:      [2] cache_result!(interp::BaseBenchmarks.InferenceBenchmarks.InferenceBenchmarker, result::Core.Compiler.InferenceResult)
      From worker 3:        @ Core.Compiler ./compiler/typeinfer.jl:391                                                                                                                                                                                    
      From worker 3:      [3] _typeinf(interp::BaseBenchmarks.InferenceBenchmarks.InferenceBenchmarker, frame::Core.Compiler.InferenceState)                                                                                                               
      From worker 3:        @ Core.Compiler ./compiler/typeinfer.jl:270                                                                                                                                                                                    
      From worker 3:      [4] typeinf(interp::BaseBenchmarks.InferenceBenchmarks.InferenceBenchmarker, frame::Core.Compiler.InferenceState)                                                                                                                
      From worker 3:        @ Core.Compiler ./compiler/typeinfer.jl:219

Please sign in to comment.