diff --git a/base/sparse/umfpack.jl b/base/sparse/umfpack.jl index 3b426bb9f234d..25f4b9935a7d1 100644 --- a/base/sparse/umfpack.jl +++ b/base/sparse/umfpack.jl @@ -157,7 +157,6 @@ lufact{T<:AbstractFloat}(A::Union{SparseMatrixCSC{T},SparseMatrixCSC{Complex{T}} "sparse floating point LU using UMFPACK or lufact(full(A)) for generic ", "dense LU."))) lufact(A::SparseMatrixCSC) = lufact(float(A)) -lufact(A::SparseMatrixCSC, pivot::Type{Val{false}}) = lufact(A) size(F::UmfpackLU) = (F.m, F.n) diff --git a/test/sparsedir/umfpack.jl b/test/sparsedir/umfpack.jl index 6db636a20353e..6ce7877e58011 100644 --- a/test/sparsedir/umfpack.jl +++ b/test/sparsedir/umfpack.jl @@ -136,4 +136,12 @@ let @test_throws ArgumentError Base.SparseArrays.UMFPACK.solve!(a, lufact(speye(5,5)), a, Base.SparseArrays.UMFPACK.UMFPACK_A) aa = complex(a) @test_throws ArgumentError Base.SparseArrays.UMFPACK.solve!(aa, lufact(complex(speye(5,5))), aa, Base.SparseArrays.UMFPACK.UMFPACK_A) -end \ No newline at end of file +end + +#18246,18244-lufact sparse pivot +let + A = speye(4) + A[1:2,1:2] = [-.01 -200; 200 .001] + F = lufact(A) + @test F[:p] == [3 ; 4 ; 2 ; 1] +end