Skip to content

Commit

Permalink
Deprecate old dense matrix factorization names.
Browse files Browse the repository at this point in the history
  • Loading branch information
@ViralBShah
ViralBShah committed Feb 7, 2013
1 parent 2fe3c04 commit b259333
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions base/deprecated.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ end
@deprecate chars collect
@deprecate elements collect
@deprecate strcat string
@deprecate chold chol
@deprecate cholpd cholpivot
@deprecate lud lu
@deprecate qrd qr
@deprecate qrpd qrpivot

export randi
function randi(n,x...)
Expand Down

2 comments on commit b259333

@StefanKarpinski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks a lot of code. I guess maybe we're ok with that and I can't see any other way, but just saying.

@ViralBShah
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you used those names, the new names are exact replacements. The codes that break are the matlab names, which now return factorization objects instead of the matlab behaviour.

Please sign in to comment.