Skip to content

Commit

Permalink
Add test
Browse files Browse the repository at this point in the history
  • Loading branch information
@gbaraldi
gbaraldi committed Feb 6, 2023
1 parent 91e9f66 commit dd9291a
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions test/hashing.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -284,3 +284,11 @@ end
end
end
end

if Sys.WORD_SIZE >= 64
@testset "very large string" begin
N = 2^31+1
s = String('\0'^N);
objectid(s)
end
end

2 comments on commit dd9291a

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on dd9291a Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not certain we should allocate a buffer this large on CI

@gbaraldi
Copy link
Member Author

@gbaraldi gbaraldi commented on dd9291a Feb 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's like 2GB long right? It does run quite fast on my machine, even with high memory pressure so I'm not sure how big of an issue it is.
Do you have an idea for a different test?

Please sign in to comment.