move Serializer to stdlib
#25628
Merged
move Serializer to stdlib
#25628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
deprecation
vtjnash
reviewed
Jan 18, 2018
base/loading.jl
Outdated
| @@ -582,16 +583,17 @@ function create_expr_cache(input::String, output::String, concrete_deps::typeof( | |||
| empty!(Base._concrete_dependencies) | |||
| append!(Base._concrete_dependencies, $concrete_deps) | |||
| Base._track_dependencies[] = true | |||
| end) | |||
| end\0 | |||
There was a problem hiding this comment.
While effectively the same, might be clearer to splice in repr(...) explicitly?
vtjnash
reviewed
Jan 18, 2018
| pkg = deserialize(f) | ||
| err = deserialize(f) | ||
| pkg = chop(readuntil(f, '\0')) | ||
| err = chop(readuntil(f, '\0')) |
There was a problem hiding this comment.
The result of readuntil includes the delimiter. I guess we could change that, since we already made that change to readline.
JeffBezanson
force-pushed
the
jb/mvserializer
branch
2 times, most recently
from
493c3a3 to
6c85618
Compare
JeffBezanson
force-pushed
the
jb/mvserializer
branch
from
6c85618 to
2f1bdee
Compare
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base only uses this in two places: precompile and pkg/entry. I changed them to use Good Ol' Strings.
Did some renaming as well. The package is now called
Serialization, andSerializationStateis renamedSerializerto go withAbstractSerializerand its other subtypeClusterSerializer.