spawn/IO: supercharge the API #30278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
io
vtjnash
force-pushed
the
jn/spawn-any-stdio
branch
from
58c02e2 to
c30f968
Compare
vtjnash
removed
needs news
- Permit IOBuffer as an input/output, and automatically create a Pipe to feed to/from it. - Improved handling for using CmdRedirect on fd >= 3 - Allow any number of stdio handles to be passed to the child (including zero), not just precisely 0-2 - Clearer ownership expectations (less code duplication) in `_spawn` calls, ensuring we always call `setup_stdio` early and exactly once - Stop capturing all IO handles in Process.in/.out/.err Since usually we only have the child side of the handle at the point we were trying to set this, while we want this to be the parent handle. Instead, we now handle this at the caller level in the `open` method, which has better information and intent given for this. (To preserve the old behavior, we also include the old heuristic in `run` for setting these handles.) - Ensure that most of the code won't need to be specialized on every (stdin, stdout, stderr) tuple combination that gets used - Implement `open(::OS_HANDLE)` for taking ownership of a raw `fd` handle, and the corresponding constructors `PipeEndpoint(::OS_HANDLE)` and `TCP(::OS_HANDLE)` (such as may now be passed via CmdRedirect).
vtjnash
force-pushed
the
jn/spawn-any-stdio
branch
from
c30f968 to
4cc3e62
Compare
ararslan
reviewed
Dec 7, 2018
Co-Authored-By: vtjnash <vtjnash@gmail.com>
vtjnash
commented
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been long requested that we allow passing an IOBuffer to spawn and make it "just work". And there were just a number of other cleanup tasks to execute to improve the internal API.