-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Channel constructor keyword argument to @spawn
new Task in parallel
#32872
Merged
JeffBezanson
merged 6 commits into
JuliaLang:master
from
NHDaly:Channel-constructors-mulithreading
Aug 15, 2019
Merged
Add Channel constructor keyword argument to @spawn
new Task in parallel
#32872
JeffBezanson
merged 6 commits into
JuliaLang:master
from
NHDaly:Channel-constructors-mulithreading
Aug 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a parameter to the Channel constructor to allow the Tasks it creates to be scheduled on multiple threads. Examples: ```julia # Spawn a Task to handle each input request ch = Channel{String}(0, spawn=true) do ch handle_request(ch, request) end ```
NHDaly
force-pushed
the
Channel-constructors-mulithreading
branch
from
August 12, 2019 13:51
acc1d40
to
269a22b
Compare
NHDaly
commented
Aug 12, 2019
@JeffBezanson This should be the last of my Channel constructor PRs. 😄 Thanks for the help reviewing them! |
- improve docstrings for Channel constructors Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com>
…nly constructor Adds a manual check that users don't use the `spawn=` keyword argument with the deprecated keyword arguments `ctype=` or `csize=`.
NHDaly
changed the title
Add Channel constructor kwparam to
Add Channel constructor keyword argument to Aug 15, 2019
@spawn
new Task in parallel@spawn
new Task in parallel
JeffBezanson
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
spawn=
keyword argument toChannel()
, which causes the newTask
created for the providedfunc
to be scheduled on any thread, in parallel, equivalent to creating the task via@spawn
.Defaults to false for backwards compatability.
This adds the param to the new constructor added in #32818, and updates the NEWS item.