Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.7.0beta4 atomics.h errors embedding Julia in C++ Windows 10 MSVC 2019 v142 #42098

Closed
solaris783 opened this issue Sep 2, 2021 · 0 comments · Fixed by #42152
Closed
Assignees

Comments

@solaris783
Copy link

I get a host of compile errors (about 30) by trying to compile the simple "Embedding Julia in C++" https://docs.julialang.org/en/v1/manual/embedding/.

Here are the first 5:

1>C:\Users\VitalRoberto\AppData\Local\Programs\Julia-1.7.0-beta4\include\julia\julia_threads.h(321,5): error C2065: ‘__ATOMIC_SEQ_CST’: undeclared identifier
1>C:\Users\VitalRoberto\AppData\Local\Programs\Julia-1.7.0-beta4\include\julia\julia_threads.h(321,5): error C3861: ‘__atomic_signal_fence’: identifier not found
1>C:\Users\VitalRoberto\AppData\Local\Programs\Julia-1.7.0-beta4\include\julia\julia_threads.h(321,5): error C2065: ‘__ATOMIC_RELEASE’: undeclared identifier
1>C:\Users\VitalRoberto\AppData\Local\Programs\Julia-1.7.0-beta4\include\julia\julia_threads.h(321,5): error C3861: ‘__atomic_store_n’: identifier not found
1>C:\Users\VitalRoberto\AppData\Local\Programs\Julia-1.7.0-beta4\include\julia\julia_threads.h(325,9): error C2065: ‘__ATOMIC_SEQ_CST’: undeclared identifier

in 1.7, atomics.h doesn’t have good definitions for MSVC.
I copied the atomics.h from Julia 1.6.5 and got it to work (also had to define jl_atomic_cmpswap). Seems like someone overlooked this platform.

@vtjnash vtjnash self-assigned this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants