-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
concrete evaluation should never happen for uncompileable callsite #49050
Milestone
Comments
aviatesk
added a commit
that referenced
this issue
Mar 21, 2023
In rare cases, the system might decide to widen the signature of a call that is determined to throw by concrete-evaluation. We should remove this unnecessary assertion here. closes #49050
aviatesk
added a commit
that referenced
this issue
Mar 21, 2023
In rare cases, the system might decide to widen the signature of a call that is determined to throw by concrete-evaluation. We should remove this unnecessary assertion here. closes #49050
aviatesk
added a commit
that referenced
this issue
Mar 21, 2023
In rare cases, the system might decide to widen the signature of a call that is determined to throw by concrete-evaluation. We should remove this unnecessary assertion here. closes #49050
Keno
pushed a commit
that referenced
this issue
Mar 21, 2023
…#49074) * inlining: allow non-compileable result when handling `ConcreteResult` In rare cases, the system might decide to widen the signature of a call that is determined to throw by concrete-evaluation. We should remove this unnecessary assertion here. closes #49050 * Update test/compiler/inline.jl Co-authored-by: Jameson Nash <vtjnash@gmail.com> --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this issue
Apr 19, 2023
…JuliaLang#49074) * inlining: allow non-compileable result when handling `ConcreteResult` In rare cases, the system might decide to widen the signature of a call that is determined to throw by concrete-evaluation. We should remove this unnecessary assertion here. closes JuliaLang#49050 * Update test/compiler/inline.jl Co-authored-by: Jameson Nash <vtjnash@gmail.com> --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running the tests for ColorTypes (v0.11.4) on nightly (with #49048, which should be inconsequential for this issue), I get
The text was updated successfully, but these errors were encountered: