Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize jl_binding_t in sysimg #5125

Closed
vtjnash opened this issue Dec 13, 2013 · 3 comments
Closed

optimize jl_binding_t in sysimg #5125

vtjnash opened this issue Dec 13, 2013 · 3 comments
Assignees
@JeffBezanson
Labels
performance Must go faster

Comments

@vtjnash
Copy link
Member

vtjnash commented Dec 13, 2013

making jl_binding_t a statically allocated variable should be nice for performance.
@ghost ghost assigned vtjnash Dec 13, 2013
@vtjnash vtjnash mentioned this issue Dec 13, 2013
Merged
11 tasks
@JeffBezanson JeffBezanson mentioned this issue Dec 14, 2013
Merged
@JeffBezanson JeffBezanson assigned JeffBezanson and unassigned vtjnash Feb 28, 2014
@JeffBezanson JeffBezanson mentioned this issue Mar 12, 2014
Closed
@Keno Keno modified the milestones: 0.4, 0.3 Mar 19, 2014
@JeffBezanson
Copy link
Member

We suspect this is probably not a huge issue (we don't spend much time reading globals, and they're kind of slow anyway). Moved to 0.4.

@vtjnash vtjnash modified the milestones: 0.5, 0.4.x Aug 23, 2015
@vtjnash
Copy link
Member Author

vtjnash commented Aug 23, 2015

moving this again, since it's not even measurable as a performance issue during profiling

@vtjnash vtjnash removed this from the 0.5.0 milestone Mar 14, 2016
@vtjnash vtjnash closed this as completed Jul 11, 2016
@vtjnash
Copy link
Member Author

vtjnash commented Jul 11, 2016

It's unclear why we would do this, since it doesn't show up as an actual issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vtjnash @JeffBezanson @Keno