Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inferior-julia comint mode #10389

Merged
merged 8 commits into from
Mar 9, 2015
Merged

Added inferior-julia comint mode #10389

merged 8 commits into from
Mar 9, 2015

Conversation

Elzair
Copy link
Contributor

@Elzair Elzair commented Mar 3, 2015

I added a comint-mode for julia. Now, one can run the Julia interpreter in Emacs with M-x inferior-julia

@pao pao added the julia-mode label Mar 3, 2015
@Elzair
Copy link
Contributor Author

Elzair commented Mar 4, 2015

I have also changed the input mode for the Julia buffer to TeX, so it can now do TeX formatting.

@pao
Copy link
Member

pao commented Mar 4, 2015

cc @Wilfred

;; Code for `inferior-julia-mode'
(require 'comint)

(defvar julia-file-path "/usr/bin/julia" "Path to the program used by `inferior-julia'.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nicer to use defcustom here, what do you think? I'd also suggest just using "julia" rather than hard-coding the path.

@Wilfred
Copy link
Contributor

Wilfred commented Mar 5, 2015

Thanks, this is really good! Left a few minor comments, let me know what you think/whether they make sense :).

@Elzair
Copy link
Contributor Author

Elzair commented Mar 5, 2015

I like the suggestions. I enabled julia-mode unicode input in inferior-julia-mode, changed both julia-file-path and julia-arguments to customizable variables (under the group "Julia" in "Programming->Languages"), removed the absolute file path in julia-file-path (renamed to julia-program), and finally changed the buffer name to *Julia*

@Wilfred
Copy link
Contributor

Wilfred commented Mar 5, 2015

It's still probably worth adding an autoload cookie so users can call M-x inferior-julia without being required to write (require 'julia).

Anyway, this is really good thing to have in julia-mode.el 👍

@Elzair
Copy link
Contributor Author

Elzair commented Mar 6, 2015

Okay, the autoload cookie has been added

@Elzair
Copy link
Contributor Author

Elzair commented Mar 9, 2015

Does everything look good?

@pao
Copy link
Member

pao commented Mar 9, 2015

@Wilfred I'm merging since it looks like this addresses your comments. Feel free to follow up if I've ruined everything.

pao added a commit that referenced this pull request Mar 9, 2015
Added inferior-julia comint mode
@pao pao merged commit 5bacb18 into JuliaLang:master Mar 9, 2015
@Wilfred
Copy link
Contributor

Wilfred commented Mar 9, 2015

Marvellous, I was about to ask you to merge it. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants