From efe9a17575342505e596d4773cfbfee44671da71 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ismael=20Venegas=20Castell=C3=B3?= <ismael.vc1337@gmail.com>
Date: Sun, 21 Jun 2015 10:30:53 -0500
Subject: [PATCH 1/2] Add tests for sort coverage.

---
 test/sorting.jl | 29 +++++++++++++++++++++++++----
 1 file changed, 25 insertions(+), 4 deletions(-)

diff --git a/test/sorting.jl b/test/sorting.jl
index f62acc1889407..23f20fba59c83 100644
--- a/test/sorting.jl
+++ b/test/sorting.jl
@@ -1,5 +1,7 @@
 # This file is a part of Julia. License is MIT: http://julialang.org/license
 
+using Base.Order: Forward
+
 @test sort([2,3,1]) == [1,2,3]
 @test sort([2,3,1], rev=true) == [3,2,1]
 @test sort(['z':-1:'a';]) == ['a':'z';]
@@ -32,8 +34,8 @@ numTypes = [ Int8,  Int16,  Int32,  Int64,  Int128,
 
 @test searchsorted([1:10;], 1, by=(x -> x >= 5)) == 1:4
 @test searchsorted([1:10;], 10, by=(x -> x >= 5)) == 5:10
-@test searchsorted([1:5; 1:5; 1:5], 1, 6, 10, Base.Order.Forward) == 6:6
-@test searchsorted(ones(15), 1, 6, 10, Base.Order.Forward) == 6:10
+@test searchsorted([1:5; 1:5; 1:5], 1, 6, 10, Forward) == 6:6
+@test searchsorted(ones(15), 1, 6, 10, Forward) == 6:10
 
 for R in numTypes, T in numTypes
     @test searchsorted(R[1, 1, 2, 2, 3, 3], T(0)) == 1:0
@@ -49,8 +51,8 @@ for R in numTypes, T in numTypes
 
     @test searchsorted(R[1:10;], T(1), by=(x -> x >= 5)) == 1:4
     @test searchsorted(R[1:10;], T(10), by=(x -> x >= 5)) == 5:10
-    @test searchsorted(R[1:5; 1:5; 1:5], T(1), 6, 10, Base.Order.Forward) == 6:6
-    @test searchsorted(ones(R, 15), T(1), 6, 10, Base.Order.Forward) == 6:10
+    @test searchsorted(R[1:5; 1:5; 1:5], T(1), 6, 10, Forward) == 6:6
+    @test searchsorted(ones(R, 15), T(1), 6, 10, Forward) == 6:10
 end
 
 for (rg,I) in [(49:57,47:59), (1:2:17,-1:19), (-3:0.5:2,-5:.5:4)]
@@ -83,6 +85,25 @@ end
 @test searchsorted([1,2,3], 0) == 1:0
 @test searchsorted([1,2,3], 4) == 4:3
 
+immutable ConstantRange{T} <: Range{T}
+   val::T
+   len::Int
+end
+
+Base.length(r::ConstantRange) = r.len
+Base.getindex(r::ConstantRange, i::Int) = (1 <= i <= r.len || throw(BoundsError(r,i)); r.val)
+Base.step(r::ConstantRange) = 0
+
+r = ConstantRange(1, 5)
+
+@test searchsortedfirst(r, 1.0, Forward) == 1
+@test searchsortedfirst(r, 1, Forward) == 1
+@test searchsortedfirst(r, UInt(1), Forward) == 1
+
+@test searchsortedlast(r, 1.0, Forward) == 5
+@test searchsortedlast(r, 1, Forward) == 5
+@test searchsortedlast(r, UInt(1), Forward) == 5
+
 a = rand(1:10000, 1000)
 
 for alg in [InsertionSort, MergeSort]

From f1b7b6267b35cc3c4f99ca5acd3d3c9ccba5f151 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ismael=20Venegas=20Castell=C3=B3?= <ismael.vc1337@gmail.com>
Date: Mon, 22 Jun 2015 08:58:57 -0500
Subject: [PATCH 2/2] Add informative comment.

---
 test/sorting.jl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/sorting.jl b/test/sorting.jl
index 23f20fba59c83..b2843d784d2e9 100644
--- a/test/sorting.jl
+++ b/test/sorting.jl
@@ -85,6 +85,7 @@ end
 @test searchsorted([1,2,3], 0) == 1:0
 @test searchsorted([1,2,3], 4) == 4:3
 
+# exercise the codepath in searchsorted* methods for ranges that check for zero step range
 immutable ConstantRange{T} <: Range{T}
    val::T
    len::Int