Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better cmdline option error handling (fixes #12679) #13245

Merged
merged 1 commit into from
Sep 21, 2015
Merged

better cmdline option error handling (fixes #12679) #13245

merged 1 commit into from
Sep 21, 2015

Conversation

nolta
Copy link
Member

@nolta nolta commented Sep 20, 2015

Moves all the cmdline option error handling code from client.jl to repl.c. Fixes #12679.

Before:

$ ./julia --compile=yes -foo
julia: unknown option `--compile=yes`

After:

$ ./julia --compile=yes -foo
ERROR: unknown option `-o`

Easier to read with the ?w=1 flag: dff1c90?w=1

@nolta
better cmdline option err handling (fixes #12679)
dff1c90 
Moves all the cmdline option error handling code from client.jl to
repl.c.
@jakebolewski
Copy link
Member

LGTM

jakebolewski added a commit that referenced this pull request Sep 21, 2015
@jakebolewski
Merge pull request #13245 from JuliaLang/mn/12679
2c59bc1 
better cmdline option error handling (fixes #12679)
@jakebolewski jakebolewski merged commit 2c59bc1 into master Sep 21, 2015
@yuyichao yuyichao deleted the mn/12679 branch September 21, 2015 12:34
@tkelman
Copy link
Contributor

tkelman commented Sep 21, 2015

I dont want to backport this until after 0.4.0 as it's a pretty substantial change.

@tkelman tkelman added this to the 0.4.1 milestone Sep 21, 2015
nolta added a commit that referenced this pull request Oct 31, 2015
@nolta @tkelman
better cmdline option err handling (fixes #12679)
192e140 
Moves all the cmdline option error handling code from client.jl to
repl.c.

(cherry picked from commit dff1c90)
ref #13245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nolta @jakebolewski @tkelman