Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Some fixes for summary, show, and map for non-1 indices" #17769

Closed
wants to merge 1 commit into from

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Aug 2, 2016

@tkelman
Copy link
Contributor Author

tkelman commented Aug 2, 2016

Having trouble reproducing the failure locally so maybe it's an intermittent thing.

@yuyichao
Copy link
Contributor

yuyichao commented Aug 2, 2016

Note that the linked failure is on my WIP pr. So it could be caused by that PR.

@tkelman
Copy link
Contributor Author

tkelman commented Aug 2, 2016

Yeah I think I didn't call this one right. Once in a while we do see PR's that pass when CI runs on them, but fail after merged into master because of some other change that got merged in the interim, but this probably was not one of those cases.

@tkelman tkelman closed this Aug 2, 2016
@timholy
Copy link
Member

timholy commented Aug 3, 2016

This was a pretty unlikely one to cause trouble---anything that touches map is of course a little scary, but really it was all obvious stuff and should be as wholesome as apple pie.

@tkelman tkelman deleted the revert-17729-teh/summary_indices branch August 3, 2016 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants