[skip ci] Make comment describing add22condh meaningful #21985
Conversation
base/math.jl
Outdated
| # as above, but only compute and return high double | ||
| # This algorithm, due to Dekker, computes the sum of | ||
| # two double-double numbers and return high double. References: | ||
| # [1] http://gdz.sub.uni-goettingen.de/dms/load/img/?PPN=PPN362160546_0018&DMDID=DMDLOG_0023&LOGID=LOG_0023&PHYSID=PHYS_0232 |
There was a problem hiding this comment.
This seems like an overly long and likely-to-be-transient URL. Anything shorter/more permanent?
There was a problem hiding this comment.
The two links point to two versions of the same paper. The second one is a DOI, so should be permanent by definition of DOI, but the article is under a paywall there. Regarding the first link, I don't speak German, but the site looks like a digital library. http://www.digizeitschriften.de/dms/img/?PID=GDZPPN001170007 is a shorter URL and it's where the link on top of the page links to.
There was a problem hiding this comment.
That second shorter link looks more likely to be stable – the other link looks like it's part of their internal content delivery setup.
There was a problem hiding this comment.
First link replaced with http://www.digizeitschriften.de/en/dms/img/?PID=GDZPPN001170007 Thanks!
giordano
force-pushed
the
add22condh-comment
branch
from
0b146f6 to
60597c0
Compare
| @@ -716,7 +716,10 @@ end | |||
| ## rem2pi-related calculations ## | |||
|
|
|||
| function add22condh(xh::Float64, xl::Float64, yh::Float64, yl::Float64) | |||
| # as above, but only compute and return high double | |||
| # This algorithm, due to Dekker, computes the sum of | |||
| # two double-double numbers and return high double. References: | |||
PR #4862 removed a bunch of functions together with their comments.
add22condhsurvived, but the comment describing this function refers to the comment of a deleted function. This PR basically resurrects and adapts the deleted comment, but please check for correctness of the comment ;-)For reference, the deleted comment was here:
julia/base/math.jl
Lines 1343 to 1346 in 4d83f89