-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ieee754_rem_pio2 in favor of a rem_pio2_kernel written in Julia. #22603
Merged
Merged
Changes from 25 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
3f951d1
Remove ieee754_rem_pio2 in favor of a rem_pio2_kernel written in Julia.
pkofod 62a91ed
Add missing begin key.
pkofod 16ec5f0
Remove _approx.
pkofod 6f8e725
Move to separate files.
pkofod c6f593e
Fix LICENSE.md to mention FDLIBM instead of Openlibm.
pkofod 5fd35f4
Address comments.
pkofod 1d2faa6
Strengthen test to faithfully rounded.
pkofod 7878d2c
Fix LICENSE.md message for rem_pio2.
pkofod 0017edd
Fix style in LICENSE.md entry.
pkofod 8258c48
Remove semicolons.
pkofod 83da1a2
Move highword up, and remove duplicate unsafe_trunc.
pkofod 27455bf
Fix LICENSE.md by removing a bullet and changing license of base/spec…
pkofod bb626b3
Change license info for base/special/exp.jl.
pkofod 45d4ba1
Small changes.
pkofod ff19e40
Get and reset precision for BigFloats, and space before rem in -rem.
pkofod 375b8af
setprecision do
pkofod 8ca63c1
Add comments, move test, and switch to muladd in some places.
pkofod 1ef4918
Fix y1 branches of rem2pi.
pkofod a1f1c34
Small changes.
pkofod ecc6963
Move comment in rem_pio2.jl and add test for fast branch of mod2pi.
pkofod f8090f5
rint docstring fix and make it clear what the constant is.
pkofod eed7e62
Update comment for INV2PI.
pkofod dd2c152
Fix wrong test set name.
pkofod c06e2f3
Tests against ieee754_rem_pio2 output.
pkofod 6a5dc4a
Inline cody_waite functions.
pkofod 50e52e3
rint -> round, remove rint, remove one argument cody waite, replace I…
pkofod 7b6213e
Add some tests.
pkofod ae8577c
Inline rem_pio2_kernel, and rearrange code slightly.
pkofod ba62caf
fix xhp
pkofod f209c0a
Use DoubleFloat64.
pkofod 994e158
Move constants into functions.
pkofod aba4579
Fix escaping of mod
pkofod 4865a41
Fix tests and remove specific variables.
pkofod 6dda42c
Fix tests
pkofod 8adb120
Fix issues raised in comments.
pkofod 0545479
More appropriate ulp test (test against eps of reference number).
pkofod 8ee70a1
Merge branch 'master' into rempio2gsoc
pkofod 765c566
Change link to a stable github link.
pkofod 32d2839
Merge remote-tracking branch 'pkofod/rempio2gsoc' into rempio2gsoc
pkofod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this a bug or does your version work differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bug. If you look at
julia/base/math.jl
Line 730 in c463c1f
add22condh(y1, y2, 0.0, 0.0)
. This would then beso basically we can just return
y1+y2
directly.Are you asking because you'd like a test added, a separate commit for this change, or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test for the values that caused this to fail before in terms of the output of
rem_pio2_kernel
and the returned values ofmod2pi
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this new test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was that
mod2pi
didn't sum in the fast path, so I believe this should test regressions for the problematic cases https://github.com/JuliaLang/julia/pull/22603/files#diff-19d4f20c458e9ad8dbbfb73aea003c5eR211 ?