remove misleading bidiag constructor, make Bidiagonal immutable #22750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jul 11, 2017
| @@ -27,7 +27,6 @@ srand(1) | |||
| @test Bidiagonal(dv,ev,:U) != Bidiagonal(dv,ev,:L) | |||
| @test_throws ArgumentError Bidiagonal(dv,ev,:R) | |||
| @test_throws DimensionMismatch Bidiagonal(dv,ones(elty,n),:U) | |||
| @test_throws ArgumentError Bidiagonal(dv,ev) | |||
There was a problem hiding this comment.
change to MethodError instead?
There was a problem hiding this comment.
Sure, seems a bit ambitions to test a non-existing method though.
There was a problem hiding this comment.
well it used to exist but only for the purpose of throwing an error, so if it accidentally were brought back (say an incorrect use of a default third argument?) that could be surprising
fredrikekre
force-pushed
the
fe/bidiagonal2
branch
from
e34e35b to
0102073
Compare
|
#22756 on macOS, tests relevant for this PR passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22703 (comment)
Also changed
Bidiagonalto an immutable, likeDiagonaland[Sym]Tridiagonal