fix LAPACK.ormlq! and postmultiplication with LQPackedQ #23803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
bugfix
Sacha0
commented
Sep 21, 2017
| # the number of rows of the matrix of which Q is a factor (i.e. size(Q.factors, 1)), | ||
| # and if so zero-extends A as necessary for check (1) to pass (if possible). | ||
| *(A::StridedVecOrMat, Q::LQPackedQ) = _A_mul_Bq(A_mul_B!, A, Q) | ||
| A_mul_Bc(A::StridedVecOrMat, Q::LQPackedQ) = _A_mul_Bq(A_mul_Bc!, A, Q) |
There was a problem hiding this comment.
This method does not require LQPackedQ's context-dependent multiplication behavior, as LQPackedQ's second dimension is not context-dependent.
| return A_mul_Bop!(C, convert(AbstractMatrix{TR}, Q)) | ||
| end | ||
| Ac_mul_B(A::StridedMatrix, Q::LQPackedQ) = _Ac_mul_Bq(A_mul_B!, A, Q) | ||
| Ac_mul_Bc(A::StridedMatrix, Q::LQPackedQ) = _Ac_mul_Bq(A_mul_Bc!, A, Q) |
There was a problem hiding this comment.
This method also does not require LQPackedQ's context-dependent multiplication behavior, as LQPackedQ's second dimension is not context-dependent.
andreasnoack
approved these changes
Sep 21, 2017
|
Thanks Andreas! I will prepare a followup pull request with the touchups mentioned above :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes
LAPACK.ormlq!'s shape checks, consequently fixing the bug in postmultiplication withLQPackedQs identified in JuliaLang/LinearAlgebra.jl#469.This pull request also makes(edit: botched) and tests those methods' behavior. Best!LQPackedQ's context-dependent postmultiplication behavior (see #23785 (comment)) consistent across all existing out-of-place multiplication methods (*,A[c]_mul_B[c])(The first commit is #23785, which I will rebase out.)