Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Array{...}(shape...)-like calls in base/[b-d]* #24756

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Nov 24, 2017

This pull request replaces Array{...}(shape...)-like calls in base/[b-d]*.jl. Ref. #24595. Best!

@Sacha0 Sacha0 added the arrays [a, r, r, a, y, s] label Nov 24, 2017
@fredrikekre
Copy link
Member

error during bootstrap:
LoadError(at "coreimg.jl" line 3: LoadError(at "docs/core.jl" line 10: UndefVarError(var=:Vector)))
rec_backtrace at /home/travis/build/JuliaLang/julia/src/stackwalk.c:94
record_backtrace at /home/travis/build/JuliaLang/julia/src/task.c:246
jl_throw at /home/travis/build/JuliaLang/julia/src/task.c:577
jl_undefined_var_error at /home/travis/build/JuliaLang/julia/src/rtutils.c:129
jl_eval_global_var at /home/travis/build/JuliaLang/julia/src/interpreter.c:346 [inlined]
eval_value at /home/travis/build/JuliaLang/julia/src/interpreter.c:386 [inlined]
do_call at /home/travis/build/JuliaLang/julia/src/interpreter.c:322
eval_value at /home/travis/build/JuliaLang/julia/src/interpreter.c:395 [inlined]
do_call at /home/travis/build/JuliaLang/julia/src/interpreter.c:322
eval_value at /home/travis/build/JuliaLang/julia/src/interpreter.c:395
eval_body at /home/travis/build/JuliaLang/julia/src/interpreter.c:509
jl_interpret_toplevel_thunk_callback at /home/travis/build/JuliaLang/julia/src/interpreter.c:720
unknown function (ip: 0xfffffffe)

@Sacha0
Copy link
Member Author

Sacha0 commented Nov 24, 2017

Bootstrap error should be fixed. Thanks! :)

What say you now, CI?

@Sacha0 Sacha0 force-pushed the reparrbb branch 3 times, most recently from 43f3ea7 to c12fea2 Compare November 25, 2017 04:30
@Sacha0
Copy link
Member Author

Sacha0 commented Nov 25, 2017

Chances are the Vector/Matrix/Array docstring changes cause the doc build failures on Travis and AppVeyor, though I am not certain why. I plan to separate those changes out of this pull request, and if CI then approves and absent objections or requests for time, I plan to merge these changes this evening PT or later. Best!

@Sacha0
Copy link
Member Author

Sacha0 commented Nov 25, 2017

Stripped out the docstring changes. The test/distributed failure on FreeBSD looks legitimate, so I also stripped out the base/distributed changes. Best!

@fredrikekre fredrikekre merged commit 3c1e9d0 into JuliaLang:master Nov 26, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Nov 26, 2017

Thanks @fredrikekre! :)

@Sacha0 Sacha0 deleted the reparrbb branch November 26, 2017 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants