Use promote_typejoin() to choose type parameters in Dict constructor #25805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with Array, NamedTuple and Tuple (via its eltype method),
and in particular the Dict(::AbstractArray{<:Pair}) constructor.
bkamins
reviewed
Jan 29, 2018
| Dict(ps::(Pair{K,V} where K)...) where {V} = Dict{Any,V}(ps) | ||
| Dict(ps::Pair...) = Dict{Any,Any}(ps) | ||
| Dict(ps::Pair{K,V}...) where {K,V} = Dict{K,V}(ps) | ||
| Dict(ps::Pair...) = Dict(ps) |
There was a problem hiding this comment.
Thanks! I have one question - is the first method is needed only for performance reasons or covers some special case?
There was a problem hiding this comment.
I think it's was there for performance, but that's not clear to me...
EDIT: FWIW, these constructors are very old, they have been introduced in 2d24d01 when Dict was called HashTable and before Pair existed.
|
I'll merge in a few days if nobody objects. |
Without this Dict(1=>missing, 2=>2) returns a Dict{Int,Any}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with
Array,NamedTupleandTuple(via itseltypemethod), and therefore with theDict(::AbstractArray{<:Pair})constructor.Fixes #25551.