Skip to content

Use lowered form in logging macro #26291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Use lowered form in logging macro #26291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/logging.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ function logmsg_code(_module, file, line, level, message, exs...)
quote
level = $level
std_level = convert(LogLevel, level)
if std_level >= _min_enabled_level[]
if std_level >= getindex(_min_enabled_level)
logstate = current_logstate()
if std_level >= logstate.min_enabled_level
logger = logstate.logger
Expand Down
8 changes: 8 additions & 0 deletions test/logging.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,4 +267,12 @@ end
"""
end

# Issue #26273
let m = Module(:Bare26273i, false)
eval(m, :(import Base: @error))
@test_logs (:error, "Hello") eval(m, quote
@error "Hello"
end)
end

end