uuid5 #28761
uuid5 #28761
Conversation
|
I suggest including the provided namespaces from the RFC as constants, and testing with UUID5s generated by, e.g., Python (which also provides the namespaces from the RFC as constants). |
|
I tried comparing the result of the Python lib with the current implementation and of course it's different, I'll look into it |
|
@iamed2 following your advice, Python comparisons are now integrated in the tests and should pass for I also changed the input to take the actual bytes of both the namespace and name (which was initially different from the Python implementation) |
| function uuid5(ns::UUID, name::String) | ||
| nsbytes = zeros(UInt8, 16) | ||
| nsv = ns.value | ||
| for idx in Base.OneTo(16) |
There was a problem hiding this comment.
I have a feeling this loop is not as efficient as it can get, if some bit wizards have suggestions
|
The results produced on the standard namespaces are the same as the rust ones: extern crate uuid;
use uuid::Uuid;
fn main() {
let refs = vec![&uuid::NAMESPACE_DNS, &uuid::NAMESPACE_OID, &uuid::NAMESPACE_URL, &uuid::NAMESPACE_X500];
let pairs = refs
.iter()
.map(|u|
(u, Uuid::new_v5(u, "julia"))
);
for (u1,u2) in pairs {
println!("{0} - {1}", u1, u2);
}
} |
|
Excellent :) |
|
ok "we" have one tiny problem, $ uuidgen --sha1
$ uuidgen --sha1 --namespace @dns --name julia
00ca23ad-40ef-500c-8910-157de3950d07
$ uuidgen --sha1 --namespace @oid --name julia
b7bf72b0-fb4e-538b-952a-3be296f07f6d
$ uuidgen --sha1 --namespace @url --name julia
997cd5be-4705-5439-9fe6-d77b18d612e5
$ uuidgen --sha1 --namespace @x500 --name julia
993c6684-82e7-5cdb-9d46-9bff0362e6a9Python (same as Julia and Rust) In [1]: import uuid
In [2]: uuid.uuid5(uuid.NAMESPACE_DNS,"julia")
Out[2]: UUID('00ca23ad-40ef-500c-a910-157de3950d07')
In [3]: uuid.uuid5(uuid.NAMESPACE_OID,"julia")
Out[3]: UUID('b7bf72b0-fb4e-538b-952a-3be296f07f6d')
In [4]: uuid.uuid5(uuid.NAMESPACE_URL,"julia")
Out[4]: UUID('997cd5be-4705-5439-9fe6-d77b18d612e5')
In [5]: uuid.uuid5(uuid.NAMESPACE_X500,"julia")
Out[5]: UUID('993c6684-82e7-5cdb-bd46-9bff0362e6a9')Rust source: https://gist.github.com/matbesancon/287e8d19d63ea2a14fc6459372753fe1 |
|
Sigh. It seems like matching Python and Rust is the way to go. |
|
I believe this indicates the variant, and I think you can ignore that digit. |
|
(they shouldn't be different though, as both Python and Linux' uuid-gen claim to follow RFC-4122) |
|
Maybe the variant is different though (different variant are specified by
the RFC) and it seems to match the byte change location. The weird thing
is, why is it just sometimes different?
…On Fri, Aug 24, 2018, 20:53 Eric Davies ***@***.***> wrote:
(they shouldn't be different though, as both Python and Linux' uuid-gen
claim to follow RFC-4122)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28761 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHRRsoabJMLkE_XlYFXbxheZRm62umi9ks5uUEuTgaJpZM4WC6ZJ>
.
|
|
Ohhh, I see: From the RFC:
So in that hex digit |
|
thanks for clarifying this, I was trying to find where to file a bug for uuidgen |
|
No problem, stuff like this eats at me until I figure it out 😄 |
|
should this get the 1.1 flag, since this is extending the exposed API of UUID? |
|
Yes, that's correct. It's a feature so it goes in a minor release. |
A dependency on SHA was added to UUIDs in #28761 but the Project.toml was not updated to reflect that, resulting in warnings while building Julia.
A dependency on SHA was added to UUIDs in #28761 but the Project.toml was not updated to reflect that, resulting in warnings while building Julia.
changes between Julia 1.0 and 1.1, including: - Custom .css-style for compat admonitions. - Information about compat annotations to CONTRIBUTING.md. - NEWS.md entry for PRs #30090, #30035, #30022, #29978, #29969, #29858, #29845, #29754, #29638, #29636, #29615, #29600, #29506, #29469, #29316, #29259, #29178, #29153, #29033, #28902, #28761, #28745, #28708, #28696, #29997, #28790, #29092, #29108, #29782 - Compat annotation for PRs #30090, #30013, #29978, #29890, #29858, #29827, #29754, #29679, #29636, #29623, #29600, #29440, #29316, #29259, #29178, #29157, #29153, #29033, #28902, #28878, #28761, #28708, #28156, #29733, #29670, #29997, #28790, #29092, #29108, #29782, #25278 - Documentation for broadcasting CartesianIndices (#30230). - Documentation for Base.julia_cmd(). - Documentation for colon constructor of CartesianIndices (#29440). - Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix). - Run NEWS-update.jl. Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
changes between Julia 1.0 and 1.1, including: - Custom .css-style for compat admonitions. - Information about compat annotations to CONTRIBUTING.md. - NEWS.md entry for PRs #30090, #30035, #30022, #29978, #29969, #29858, #29845, #29754, #29638, #29636, #29615, #29600, #29506, #29469, #29316, #29259, #29178, #29153, #29033, #28902, #28761, #28745, #28708, #28696, #29997, #28790, #29092, #29108, #29782 - Compat annotation for PRs #30090, #30013, #29978, #29890, #29858, #29827, #29754, #29679, #29636, #29623, #29600, #29440, #29316, #29259, #29178, #29157, #29153, #29033, #28902, #28878, #28761, #28708, #28156, #29733, #29670, #29997, #28790, #29092, #29108, #29782, #25278 - Documentation for broadcasting CartesianIndices (#30230). - Documentation for Base.julia_cmd(). - Documentation for colon constructor of CartesianIndices (#29440). - Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix). - Run NEWS-update.jl. Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Addition of NEWS and compat admonitions for important changes between Julia 1.0 and 1.1, including: - Custom .css-style for compat admonitions. - Information about compat annotations to CONTRIBUTING.md. - NEWS.md entry for PRs #30090, #30035, #30022, #29978, #29969, #29858, #29845, #29754, #29638, #29636, #29615, #29600, #29506, #29469, #29316, #29259, #29178, #29153, #29033, #28902, #28761, #28745, #28708, #28696, #29997, #28790, #29092, #29108, #29782 - Compat annotation for PRs #30090, #30013, #29978, #29890, #29858, #29827, #29754, #29679, #29636, #29623, #29600, #29440, #29316, #29259, #29178, #29157, #29153, #29033, #28902, #28878, #28761, #28708, #28156, #29733, #29670, #29997, #28790, #29092, #29108, #29782, #25278 - Documentation for broadcasting CartesianIndices (#30230). - Documentation for Base.julia_cmd(). - Documentation for colon constructor of CartesianIndices (#29440). - Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix). - Run NEWS-update.jl. Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Create UUIDs version 5 using the SHA1 hashing of another UUID (namespace) and string (name).
Special thanks to @ScottPJones for helping out with the last bits