-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Introducing libuv global lock on master #29706
Conversation
Out of curiosity, why not just continue it there? |
I rebased it against master and wanted to keep original branch name for kp/partr-based branch there. GitHub does not allow changing source branch in a PR. If I'd retarget that PR to master 1) I'd loose few partr-specific changes which I can just keep in that branch and 2) it would look like if I want to merge kp/partr :) |
It does: click Edit and then choose a different base branch. |
I know it allows to change base branch but I said it does not allow changing source branch. |
b3afd97
to
c09643c
Compare
Closes issue #14494. |
He made good point on not using |
Ah that's a real shame. I could possibly pick it up. No promises yet though, I'll have to see what's involved. @vtjnash what's your take on the order this stuff should get merged? |
In a recent compiler call we discussed this and his take was that this is completely independent of the other multithreading work. It can happen before or after—it just affects whether calling I/O from different Julia threads is safe or not, which is an issue now and would still be an issue after the other threading PRs are merged as well. |
Rebased as #31437. |
As title
Partially replaces #29606 (removing kp/partr specifics)