revert 28449 - workaround for openblas on Win64 #29856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, though it would be good to verify that this is fixed with OpenBLAS 0.3.3 by doing a build based on this branch's SHA on the 64-bit Windows buildbot. |
|
Was that done? Or should we just merge and see? |
Not by me. If we do it now we should rebase the branch on master first. |
vchuravy
force-pushed
the
vc/revert28449
branch
from
812b64f to
5c49f05
Compare
|
Build triggered as https://build.julialang.org/#/builders/64/builds/462 |
|
The build failed, looks related. |
vchuravy
force-pushed
the
vc/revert28449
branch
from
5c49f05 to
c6a07a4
Compare
KristofferC
force-pushed
the
vc/revert28449
branch
from
c6a07a4 to
9ad8183
Compare
|
Rebased, @vchuravy, should this be merged now? |
Probably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer necessary on OpenBLAS 0.3.3. (#29845)