Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Channel constructors, change kwargs to positional args. #32818

Merged
merged 6 commits into from
Aug 11, 2019
Merged

Simplify Channel constructors, change kwargs to positional args. #32818

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2c8796
Fix method overwrite warning for Channel constructors
NHDaly Aug 7, 2019
045ac09
Make Channel constructors interface more Julian
NHDaly Aug 9, 2019
3a547d0
Fix test/channels.jl to use newer Channel constructor
NHDaly Aug 9, 2019
b04fb84
Added new Channel constructor to news
NHDaly Aug 9, 2019
26b3e1c
Add Channel(f, size) = Channel{Any}(...) for default T for task const…
NHDaly Aug 9, 2019
0d296b1
Merge branch 'master' into Channel-constructors
NHDaly Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions base/channels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ true
The following constructors were added in Julia 1.3.

Other constructors:
* `Channel{T}(func::Function, sz=0)`
* `Channel{T}(func::Function, size)`
* `Channel{T}(func::Function; csize=0, taskref=nothing)`
NHDaly marked this conversation as resolved.
Show resolved Hide resolved

```jldoctest
Expand All @@ -129,8 +129,8 @@ function Channel(func::Function; ctype=Any, csize=0, taskref=nothing)
isa(taskref, Ref{Task}) && (taskref[] = task)
return chnl
end
function Channel{T}(f::Function, sz=0) where T
return Channel(f, csize=sz, ctype=T)
function Channel{T}(f::Function, size) where T
return Channel(f, csize=size, ctype=T)
end
function Channel{T}(f::Function; csize=0, taskref=nothing) where T
return Channel(f, csize=csize, ctype=T, taskref=taskref)
NHDaly marked this conversation as resolved.
Show resolved Hide resolved
Expand Down