Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1d/2d array method error message with unsupported keyword arg #36325

Merged
merged 3 commits into from
Dec 1, 2020
Merged

fix 1d/2d array method error message with unsupported keyword arg #36325

merged 3 commits into from
Dec 1, 2020

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Jun 17, 2020

based on #36321

@Moelf
Copy link
Contributor Author

Moelf commented Jul 10, 2020

bump

@StefanKarpinski
Copy link
Member

Who would be good to review this?

@mbauman mbauman mentioned this pull request Jul 10, 2020
Closed
@mbauman
Copy link
Member

mbauman commented Jul 10, 2020

This is a decent band-aid, IMO. It'd be easier to do something better with the just-filed #36611 or by transforming the usage here to call hasmethod instead, but I think the current workaround is good enough (even if not ideal)

It'd be nice to add a few simple tests, though.

@mbauman mbauman added error messages Better, more actionable error messages needs tests Unit tests are required for this change labels Jul 10, 2020
Moelf added a commit to Moelf/julia that referenced this pull request Jul 11, 2020
@Moelf
add tests for JuliaLang#36325
0bed290
@Moelf
Copy link
Contributor Author

Moelf commented Jul 11, 2020

tests added ;)

@Moelf
Copy link
Contributor Author

Moelf commented Jul 18, 2020

not sure why doctest failed; anything else needed?

@Moelf Moelf requested a review from mbauman October 8, 2020 20:53
@Moelf
Copy link
Contributor Author

Moelf commented Nov 2, 2020 •
edited
Loading

bump for getting on 1.6 waggon

@mbauman mbauman closed this Nov 2, 2020
@mbauman mbauman reopened this Nov 2, 2020
@mbauman mbauman added merge me PR is reviewed. Merge when all tests are passing and removed needs tests Unit tests are required for this change labels Nov 2, 2020
JeffBezanson
JeffBezanson reviewed Nov 19, 2020
View reviewed changes
test/errorshow.jl Outdated Show resolved Hide resolved
@Moelf @JeffBezanson
Update test/errorshow.jl
3683b5e 
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
@StefanKarpinski StefanKarpinski merged commit f89a83a into JuliaLang:master Dec 1, 2020
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson left review comments

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
error messages Better, more actionable error messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Moelf @StefanKarpinski @mbauman @JeffBezanson @DilumAluthge