build: make libunwind linked dynamically #36697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Off topic here, but linking libuv dynamically would likely fix #34627. Generally 👍 to dynamically linking more dependencies. 🙂 |
|
This is now dependent on us building libosxunwind.dylib correctly (JuliaLang/libosxunwind#16) |
vtjnash
force-pushed
the
jn/libunwind-dylib
branch
from
040c196 to
104ba90
Compare
|
IIRC the problem was that we would pick up libosxunwind from libSystem. Do your build system tweaks fix that? Also, separate from this PR, but we should switch our upstream to the LLVM copy to pick up aarch64 support. |
|
Possibly—our dylib had accidentally just been an empty shell re-exporting libSystem. Can’t say it will work now, but definitely wouldn’t have worked before. And agreed we should attempt to apply our diff on top of a newer release. |
Not sure why this was first linked statically, as the commit that introduced this simply had the message "restoring stuff that seems to have been clobbered by the revert of the unintended merge to master". Nearly all other libraries that we use are linked dynamically.
vtjnash
force-pushed
the
jn/libunwind-dylib
branch
from
104ba90 to
76a6f64
Compare
staticfloat
approved these changes
Jul 23, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Not sure why this was first linked statically, as the commit that introduced this simply had the message "restoring stuff that seems to have been clobbered by the revert of the unintended merge to master". Nearly all other libraries that we use are linked dynamically.
KristofferC
pushed a commit
that referenced
this pull request
Aug 13, 2020
Not sure why this was first linked statically, as the commit that introduced this simply had the message "restoring stuff that seems to have been clobbered by the revert of the unintended merge to master". Nearly all other libraries that we use are linked dynamically. (cherry picked from commit 9267bbf)
KristofferC
pushed a commit
that referenced
this pull request
Aug 14, 2020
Not sure why this was first linked statically, as the commit that introduced this simply had the message "restoring stuff that seems to have been clobbered by the revert of the unintended merge to master". Nearly all other libraries that we use are linked dynamically. (cherry picked from commit 9267bbf)
KristofferC
pushed a commit
that referenced
this pull request
Aug 18, 2020
Not sure why this was first linked statically, as the commit that introduced this simply had the message "restoring stuff that seems to have been clobbered by the revert of the unintended merge to master". Nearly all other libraries that we use are linked dynamically. (cherry picked from commit 9267bbf)
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2020
Not sure why this was first linked statically, as the commit that introduced this simply had the message "restoring stuff that seems to have been clobbered by the revert of the unintended merge to master". Nearly all other libraries that we use are linked dynamically. (cherry picked from commit 9267bbf)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this was first linked statically, as the commit that
introduced this simply had the message "restoring stuff that seems to
have been clobbered by the revert of the unintended merge to master".
Nearly all other libraries that we use are linked dynamically.