Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dict key check in type inference #37418

Closed
wants to merge 1 commit into from
Closed

Fix Dict key check in type inference #37418

wants to merge 1 commit into from

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Sep 5, 2020 •
edited
Loading

This has been there since #27126 (9100329)

Judging by the use of reverse_mapping[stmt_val] below
this should either be a branch condition or an assert.

@yuyichao
Fix Dict key check in type inference
570dc1b 
This has been there since #27126 (9100329)

Dudging by the use of `reverse_mapping[stmt_val]` below
this should either be a branch condition or an assert.
@yuyichao yuyichao requested a review from Keno September 5, 2020 18:27
@KristofferC
Copy link
Member

Can be merged? cc @Keno

@Keno Keno mentioned this pull request Dec 30, 2020
Merged
@Keno Keno closed this in #39036 Dec 30, 2020
@DilumAluthge DilumAluthge deleted the yyc/typeinf/in branch March 25, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyichao @KristofferC @Keno