fix #41908, inference error in subst_trivial_bounds #41976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
bugfix
Comment on lines
+159
to
+167
| subst = try | ||
| atypes{v.ub} | ||
| catch | ||
| # Note in rare cases a var bound might not be valid to substitute. | ||
| nothing | ||
| end | ||
| if subst !== nothing | ||
| return subst_trivial_bounds(subst) | ||
| end |
There was a problem hiding this comment.
Oh boy, this is a nice example for justifying a
try
catch
else
# code that runs when no exception was thrown
endconstruct. But given that we don't have it, I guess this is fine.
vtjnash
approved these changes
Aug 24, 2021
Co-authored-by: Martin Holters <martin.holters@hsu-hh.de>
DilumAluthge
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2021
63 tasks
95 tasks
KristofferC
pushed a commit
that referenced
this pull request
Oct 29, 2021
66 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 11, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…ng#41976) Co-authored-by: Martin Holters <martin.holters@hsu-hh.de>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ng#41976) Co-authored-by: Martin Holters <martin.holters@hsu-hh.de>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #41908