[clangsa] write a checker for implicit seq_cst atomics #42323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and ensure we are using relaxed for single-threaded reader/writer
vtjnash
force-pushed
the
jn/static-analysis-implicit-atomics
branch
from
b3a2384 to
fc3ef66
Compare
vtjnash
added
Buildkite - retry failed jobs
and removed
Buildkite - retry failed jobs
labels
JeffBezanson
approved these changes
Sep 23, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
and ensure we are using relaxed for single-threaded reader/writer
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
and ensure we are using relaxed for single-threaded reader/writer
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
and ensure we are using relaxed for single-threaded reader/writer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #42152, some of these were too weakly ordered, now many are too strongly ordered. But slowly we get closer to our goal. This adds a checker that prohibits reading or writing to an atomic without explicitly specifying the memory ordering. In principle, that also makes it much closer to our Julia atomics model.